Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow register CLI to create a public register writable to anyone #1142

Closed
wants to merge 1 commit into from

Conversation

thomasmarkiewicz
Copy link
Contributor

@thomasmarkiewicz thomasmarkiewicz commented Jan 5, 2024

Description

Summary generated by Reviewpad on 05 Jan 24 21:07 UTC

This pull request includes the following changes:

  • In the register.rs file:
    • Removal of the create_public_online function.
    • Addition of a perms parameter to the create_online function, which is used to specify permissions for the new Register.
    • Updated implementation of the create_online function to use the perms parameter and create a new Register accordingly.
  • In the Cargo.lock file:
    • Addition of the sn_registers dependency.
  • In various files:
    • Importing the Permissions struct from the sn_registers module.
    • Modifying the create_and_pay_for_register function calls to include an additional argument for permissions.
  • In the data_with_churn.rs file:
    • Adding an import statement for sn_registers::Permissions.
    • Modifying the create_and_pay_for_register function call by adding an additional argument Permissions::new_owner_only.

These changes aim to provide more flexibility in creating Registers, specifying their permissions, and handling register creation and payment.

Resolves issue #1106

@reviewpad reviewpad bot requested a review from bochaco January 5, 2024 21:07
@reviewpad reviewpad bot added Large Large sized PR waiting-for-review labels Jan 5, 2024
timeout-minutes: 1
# get the counts, then the specific line, and then the digit count only
# then check we have an expected level of restarts
# TODO: make this use an env var, or relate to testnet size

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality

Suspicious comment
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

existing comment - I guess my editor did some reformatting of spaces in this file

@thomasmarkiewicz thomasmarkiewicz deleted the issues/1106 branch January 5, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Large Large sized PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant